Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(config): better naming for settlement config #868

Merged
merged 1 commit into from
May 16, 2024
Merged

chore(config): better naming for settlement config #868

merged 1 commit into from
May 16, 2024
+8 −9

Conversation

mtsitrin
Copy link
Contributor

PR Standards

Opening a pull request should be able to meet the following requirements

Close #493

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@mtsitrin mtsitrin requested a review from a team as a code owner May 16, 2024 08:53
@mtsitrin mtsitrin linked an issue May 16, 2024 that may be closed by this pull request
node_address in dymint.toml is confusing #493
Closed
@mtsitrin mtsitrin changed the title chroe(config): better naming for settlement config chore(config): better naming for settlement config May 16, 2024
danwt
danwt approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@danwt danwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

srene
srene reviewed May 16, 2024
View reviewed changes
Copy link
Contributor

@srene srene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we also add the settlement prefix to the retry params to be consistent?

@mtsitrin
Copy link
Contributor Author

shouldn't we also add the settlement prefix to the retry params to be consistent?

I thought about changing only the "confusing" fields

@danwt
Copy link
Contributor

danwt commented May 16, 2024

just an idea maybe we can use a toml lib to write this in future instead of a template
https://pkg.go.dev/github.com/BurntSushi/toml#section-readme
might be hard to add comments though

@mtsitrin mtsitrin merged commit 4474f6e into main May 16, 2024
7 checks passed
@mtsitrin mtsitrin deleted the mtsitrin/493-node_address-in-dyminttoml-is-confusing branch May 16, 2024 12:17
omritoptix pushed a commit that referenced this pull request May 18, 2024
@mtsitrin @omritoptix
chore(config): better naming for settlement config (#868)
08f3bd6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srene srene srene left review comments

@danwt danwt danwt approved these changes

Assignees
No one assigned
Labels
dym-internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node_address in dymint.toml is confusing
3 participants
@mtsitrin @danwt @srene